Open Bug 1511845 Opened 6 years ago Updated 3 years ago

WebIDL codegen should use the new formatting rules

Categories

(Core :: DOM: Bindings (WebIDL), enhancement, P5)

enhancement

Tracking

()

People

(Reporter: smaug, Unassigned)

References

Details

No description provided.
Why does it matter? Just for example codegen, or is this a request that we make all of our generated code follow the new whitespace style? The latter would be pretty difficult because we can have arbitrarily deep nesting for things like sequences and have no way to observe the 80-column limit (which was a rule in the old whitespace style anyway, and we were ignoring it anyway). For example codegen I agree this would be a good idea.
Oh, and bholley was suggesting we just pipe the output of our codegen through clang-format, but I don't really think we want to add clang-format as a build dependency.
This would definitely be p5 or so. And the reason is just consistency. It is also quite nice to look at for example the generated event implementations and in cases generator can't create certain bits, copy-paste the generated code to .h/.cpp and modify it a bit. But not a biggie.
Priority: -- → P5
Component: DOM → DOM: Core & HTML
Component: DOM: Core & HTML → DOM: Bindings (WebIDL)
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.